Add Ticket properties to support safe update #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PierreBtz
previously approved these changes
Nov 6, 2023
PierreBtz
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#629
This change adds the
safe_updateandupdated_stampproperties to theTicketclass to support Zendesk's protection against ticket update collisions as described in the Zendesk documentation.These properties will only serialize into JSON when
safe_updateis set to TRUE.I've added some unit tests for serialization and have performed some manual tests to validate:
safe_updateset to true can succeed.safe_updateset to true will result in a HTTP CONFLICT status.safe_updateset to false will succeed.