-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support List Locales operation #619
Support List Locales operation #619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@topero thanks for the addition. Change lgtm, I'd like to have a test to cover any change that might happen in the API in the future.
I know it's a pain to write a test for this library since we cannot grant access to our internal ZD testing instance to external contributors, so I can take care of the test if needed.
Sorry for the late reply, @PierreBtz. In addition, a few more attributes have been added to the "Locale" class because they were returned by our Zendesk instance although I haven't found them in Zendesk documentation. |
@topero sorry I had a rather busy week, I'll look at the PR beginning of next week in more details but at the first glance it looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm once we sort out the fields that are not documented by Zendesk.
I'm sorry for the very very long delay to answer you, @PierreBtz . On 2 October, a Zendesk Technical Account Manager was reached out with regard to this topic. In my unicorn-and-rainbows world, the documentation is updated and this PR might be kept as it was. But the reality is that I've seen no answer so far. So the undocumented fields have been removed and the tests, adjusted. Let me know if something else needs to be modified, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks for the contribution!
Hello,
We needed to support the List Locales operation and this is the change that we implemented.
We tried to follow the contributing guidelines, but feel free to comment if we missed something, please.