Add default user agent header #613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
aheritier
approved these changes
Aug 31, 2023
duemir
reviewed
Sep 4, 2023
There was a problem hiding this comment.
I also agree it is useful. However, I am not sure about the implementation. Instantiating an object to build a sting seems like an overkill to me. I probably would have added package class Headers with USER_AGENT header constant and static method defaultUserAgent. WDYT @PierreBtz ?
PierreBtz
approved these changes
Sep 4, 2023
There was a problem hiding this comment.
@duemir There is additional code needed to retrieve the artifact version. I suggested an alternate approach (#608 (comment)) reading from the MANIFEST (that should be filled by maven at build time IIRC), but it's marginally simpler.
It works as is (tested), so I'm happy, but if you have in mind another simpler approach, I'm interested.
|
@PierreBtz It is OK. I'll merge, then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default user-agent header to requests made by the client. This helps identify traffic coming from the client, but doesn't prevent users from supplying their own user-agent header.
This is slightly modified from the version found in #608. It requires that the version be written into the manifest which is accomplished by
addDefaultImplementationEntries