Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GET timezones endpoint, add ianaTimeZone field to User #594

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Add GET timezones endpoint, add ianaTimeZone field to User #594

merged 2 commits into from
Jul 7, 2023

Conversation

nkharabaruk
Copy link
Contributor

  • Added a GET time_zones endpoint
  • Add the ianaTimeZone field to the User

PierreBtz
PierreBtz requested changes Jun 26, 2023
View reviewed changes
Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution, I'd just like to double check the documentation of the url field before moving this further.

src/main/java/org/zendesk/client/v2/Zendesk.java Outdated Show resolved Hide resolved
src/main/java/org/zendesk/client/v2/model/TimeZone.java Outdated Show resolved Hide resolved
PierreBtz
PierreBtz approved these changes Jul 7, 2023
View reviewed changes
Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contribution!

@PierreBtz PierreBtz merged commit fa1e039 into cloudbees-oss:master Jul 7, 2023
@nkharabaruk nkharabaruk deleted the get_timezones branch July 12, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PierreBtz PierreBtz PierreBtz approved these changes

@duemir duemir Awaiting requested review from duemir duemir is a code owner

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkharabaruk @PierreBtz