Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Users by role cursor pagination #565

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

colbya
Copy link

@colbya colbya commented Mar 14, 2023

Added cursor pagination to getUserByRole and added a basic unit test for the method. I avoided adding admin users for the unit test. I didn't think that would be a good idea or allowed in the test environment.

Copy link
Collaborator

@PierreBtz PierreBtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@PierreBtz PierreBtz merged commit 6d89fa2 into cloudbees-oss:master Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants