-
Notifications
You must be signed in to change notification settings - Fork 252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support the 'Content Tags' resource in the Zendesk API - resolves #559 #560
Support the 'Content Tags' resource in the Zendesk API - resolves #559 #560
Conversation
@andy-may-at I'll let you refresh and finish up on this branch, then I'll merge and cut a new release. |
1d64cb7
to
a60e12f
Compare
a60e12f
to
bb691c6
Compare
ContentTag pagination sadly doesn't conform to Zendesk's standards. It uses cursor pagination, but doesn't include a `links.next` node in the response (which would normally hold the URL of the next page of results). Because of this, we have to build the 'next page URL' ourselves by extracting the `meta.after_cursor` node value & using it to add a `&page[after]=<cursorValue>` parameter to the original query URL
bb691c6
to
8f76412
Compare
@PierreBtz This PR is now complete & ready for review :) This is (I hope) the last piece of the work to support Content Tags on Help Center articles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgmt, nice work.
I'm taking the library to commit the fix on the javadoc to be able to merge and release
@PierreBtz - while doing this PR, I noticed that there's a fair bit of inconsistent whitespace in Zendesk.java, which made my IntelliJ keep try to be helpful & fix it (which I didn't want to do as part of this PR). Might be worth doing an auto-format of the whole file if you've got an IDE with appropriate code-style settings for the project :) |
@andy-may-at indeed I noticed that too (project has a lot of history with a lot of different contributors and maintainers). |
In Kotlin-land I've been using Kotlinter, which enforces the code style that you have in your .editorconfig file Not used it myself, but this maven plugin seems to do that: |
Interesting, I wasn't aware editorconfig was providing a Maven plugin. I'll have a look. |
Content Tags can be added to posts and articles to loosely group them together.
The resource is a small object {id, name, createdDate, updatedDate}
The API supports CRUD & some searching
Additional context
API documentation: https://developer.zendesk.com/api-reference/help_center/help-center-api/content_tags/
Article about how they are used: https://support.zendesk.com/hc/en-us/articles/4848925672730