Add option=terminate for delete mcis #959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seokho-son
commented
Nov 10, 2021
| @@ -1376,7 +1387,7 @@ func DelMcis(nsId string, mcisId string, option string) error { | |||
| } | |||
| } | |||
| // Check MCIS status is Terminated (not Partial) | |||
| if !(!strings.Contains(mcisStatus.Status, "Partial-") && (strings.Contains(mcisStatus.Status, StatusTerminated) || strings.Contains(mcisStatus.Status, StatusUndefined) || strings.Contains(mcisStatus.Status, StatusFailed))) { | |||
| if mcisStatus.Id != "" && !(!strings.Contains(mcisStatus.Status, "Partial-") && (strings.Contains(mcisStatus.Status, StatusTerminated) || strings.Contains(mcisStatus.Status, StatusUndefined) || strings.Contains(mcisStatus.Status, StatusFailed))) { | |||
There was a problem hiding this comment.
아주 드물게 (spider가 중간에 죽는다거나 하는 상황) , mcis 정보에 오류가 포함되어 mcisStatus.Id 가 비어 있는 경우가 있습니다. 이 경우에는 force delete 로 처리되도록 안전옵션을 추가하였습니다.
seokho-son
commented
Nov 10, 2021
| // fmt.Printf("\n\n[Info] Sleep for 5 seconds for safe MCIS-VMs termination.\n\n") | ||
| // time.Sleep(5 * time.Second) | ||
| // with terminate option, do MCIS refine and terminate in advance | ||
| if strings.EqualFold(option, ActionTerminate) { |
There was a problem hiding this comment.
case in-sensitive 비교 방식 입니다. 사용자 입력을 string으로 받으니, 대소문자를 항상 처리해야 하니 좀 귀찮긴하네요.ㅎ
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #948