Improve the X-Request-Id and Request Details handling mechanism
#1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebase 후 Push 하겠습니다 :-) |
* Check `X-Request-Id` in request Header and set it if it's empty in the RequestIdAndDetailsIssuer middleware * Remove or replace common.StartRequestWithLog() - Note: common.EndRequestWithLog() will be removed or replaced
yunkon-kim
force-pushed
the
240920-12
branch
from
0b3ec5d to
eb17533
Compare
|
LGTM! |
|
/approve |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
X-Request-Idin request Header and set it if it's empty in the RequestIdAndDetailsIssuer middlewareThere are a lot of changes, but most of them are similar :-)