-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase replace-with-etcd onto upstream latest main #1693
Merged
cb-github-robot
merged 14 commits into
cloud-barista:replace-with-etcd
from
yunkon-kim:240730-09
Jul 30, 2024
Merged
Rebase replace-with-etcd onto upstream latest main #1693
cb-github-robot
merged 14 commits into
cloud-barista:replace-with-etcd
from
yunkon-kim:240730-09
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add `setup-auth.sh` and `.env`, which is used by Docker Compose * Set up or apply auth on etcd server through `etcd-setup-auth` (an ephemeral container) * Improve configuration for connecting to `etcd` and `kvstore` - Add environment variables of `etcd` - Read envs and set to the configs (including auth info) - Retry several times until you connect to the `etcd` server * Update examples for `etcd` test
* Add `.env` and set variables with interpolation in the compose file * Specify environment variables for Docker-Compose * Match the specified environment variables with the environment variables of each service * Set default values for each service environment variable
/approve |
github-actions
bot
added
the
approved
This PR is approved and will be merged soon.
label
Jul 30, 2024
cb-github-robot
merged commit Jul 30, 2024
ad90808
into
cloud-barista:replace-with-etcd
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will rebase
replace-with-etcd
onto upstream latestmain
.