Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase replace-with-etcd onto upstream latest main #1693

Merged
merged 14 commits into from
Jul 30, 2024

Conversation

yunkon-kim
Copy link
Member

This PR will rebase replace-with-etcd onto upstream latest main.

Sooyoung Kim and others added 13 commits July 26, 2024 14:17
* Add `setup-auth.sh` and `.env`, which is used by Docker Compose
* Set up or apply auth on etcd server through `etcd-setup-auth` (an ephemeral container)
* Improve configuration for connecting to `etcd` and `kvstore`
  - Add environment variables of `etcd`
  - Read envs and set to the configs (including auth info)
  - Retry several times until you connect to the `etcd` server
* Update examples for `etcd` test
* Add `.env` and set variables with interpolation in the compose file
* Specify environment variables for Docker-Compose
* Match the specified environment variables with the environment variables of each service
* Set default values ​​for each service environment variable
@yunkon-kim yunkon-kim requested a review from seokho-son as a code owner July 30, 2024 00:16
@github-actions github-actions bot added the docs Improvements or additions to documentation label Jul 30, 2024
@yunkon-kim
Copy link
Member Author

/approve

@github-actions github-actions bot added the approved This PR is approved and will be merged soon. label Jul 30, 2024
@cb-github-robot cb-github-robot merged commit ad90808 into cloud-barista:replace-with-etcd Jul 30, 2024
1 of 2 checks passed
@yunkon-kim yunkon-kim deleted the 240730-09 branch July 30, 2024 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved and will be merged soon. docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants