Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance error handling for listing custom img #1273

Merged
merged 2 commits into from
Nov 22, 2022

Conversation

seokho-son
Copy link
Member

@seokho-son seokho-son commented Nov 22, 2022

Enhance error handling for listing custom img

  • 기존: Custom Image list 시, 하나의 이미지 오브젝트에 오류가 발생해도 전체 리스트보기가 실패함
  • 개선: 개별 오류의 경우, Description에 error 메시지를 남기고 상태를 Error 로 변경

임의의 실패 항목 대응 예시

{
  "customImage": [
    {
      "namespace": "ns01",
      "id": "custom-test",
      "name": "custom-test",
      "connectionName": "azure-koreacentral",
      "sourceVmId": "g1-1",
      "cspCustomImageId": "/subscriptions/a20fed83-96bd-4480-92a9-140b8e3b7c3a/resourceGroups/cb-tumblebug-azure-koreacentral-tb/providers/Microsoft.Compute/images/custom-test-cdud7j67p30lnga5hmd0",
      "cspCustomImageName": "custom-test",
      "description": "{\"message\":\"[azure-koreacentral:myimage:custom-test] does not exist!\"}\n",
      "creationDate": "2022-11-22T13:52:10Z",
      "status": "Error"
    }
  ]
}

Update pkgs for release

@lgtm-com
Copy link

lgtm-com bot commented Nov 22, 2022

This pull request introduces 1 alert when merging 7bdbe06 into 0e46e26 - view on LGTM.com

new alerts:

  • 1 for Self assignment

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine ⚙️ that powers LGTM.com. For more information, please check out our post on the GitHub blog.

@seokho-son
Copy link
Member Author

/approve

@seokho-son seokho-son merged commit df9b389 into cloud-barista:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant