Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated script codes in cbadm #1066

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

seokho-son
Copy link
Member

fix #696

@seokho-son seokho-son requested a review from jihoon-seo as a code owner April 13, 2022 04:17
@prow-for-cloud-barista prow-for-cloud-barista bot added the approved This PR is approved and will be merged soon. label Apr 13, 2022
@seokho-son
Copy link
Member Author

/lgtm

@prow-for-cloud-barista
Copy link
Contributor

@seokho-son: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

1 similar comment
@prow-for-cloud-barista
Copy link
Contributor

@seokho-son: you cannot LGTM your own PR.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@github-actions github-actions bot added the lgtm This PR is acceptable by at least one reviewer label Apr 13, 2022
@jihoon-seo
Copy link
Member

Prow hook pod의 replica 수를 1로 줄였는데도 계속 2개씩 다는 것으로 보이네용..
/lgtm
/approve

@prow-for-cloud-barista
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@prow-for-cloud-barista
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jihoon-seo jihoon-seo merged commit 7549cca into cloud-barista:main Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This PR is approved and will be merged soon. lgtm This PR is acceptable by at least one reviewer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate cbadm test scripts, and integrate into REST API test scripts
2 participants