Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds Point-Wise Versions of the Riemann Solvers #91

Merged
merged 5 commits into from
Nov 6, 2014

Conversation

mandli
Copy link
Member

@mandli mandli commented Nov 5, 2014

No description provided.

Includes the initial version of the wrapper harness for point-wise Riemann
solver and an example of the scalar advection and acoustics point-wise Riemann
solver implementations.
Includes PyClaw build support and an acoustics example Riemann solver.
@ketch
Copy link
Member

ketch commented Nov 6, 2014

This is great. During the workshop new developers could easily take on the task of porting more solvers to the pointwise format and running some timing comparisons.

@ketch
Copy link
Member

ketch commented Nov 6, 2014

clawpack/pyclaw#473 is dependent on this, and presumably that's why it's failing. I guess we need to merge this and then do a commit to clawpack/clawpack so that that one will pass.

ketch added a commit that referenced this pull request Nov 6, 2014
[WIP] Adds Point-Wise Versions of the Riemann Solvers
@ketch ketch merged commit a59bdc0 into clawpack:master Nov 6, 2014
@ketch
Copy link
Member

ketch commented Nov 6, 2014

@mandli I merged this but now I'm not sure if you meant for it to be merged yet. Since it is working and fully backward-compatible, I figured it would be good to have a functioning prototype that people at the workshop can easily use/build on next week. Having it in master means one less obstacle.

@mandli
Copy link
Member Author

mandli commented Nov 6, 2014

I think it's fine, as you said it was meant to be safe and all the tests were passing.

@mandli mandli deleted the ptwise branch November 6, 2014 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants