Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

riemann/src/python/setup.py relies on a circular dependency #43

Closed
ahmadia opened this issue Aug 5, 2013 · 4 comments
Closed

riemann/src/python/setup.py relies on a circular dependency #43

ahmadia opened this issue Aug 5, 2013 · 4 comments
Assignees

Comments

@ahmadia
Copy link
Member

ahmadia commented Aug 5, 2013

Right now, Riemann's setup.py relies on the Fortran source being symbolically linked in to:

riemann/src/python/src

It seems that if I slightly modify the setup.py file (to look up one directory instead of down into the symbolic link), we can avoid this nasty symbolic link.

Somebody should look into this.

@rjleveque
Copy link
Member

This might be related -- a user just pointed out that doing this

git clone git://github.com/clawpack/clawpack.git  clawpack-5.2.1
cd clawpack-5.2.1
python setup.py git-dev

results in a circular set of symbolic links, e.g. you can cd to
clawpack-5.2.1/riemann/src/python/riemann/src/python/riemann/src/python/riemann

@ahmadia
Copy link
Member Author

ahmadia commented Oct 19, 2014

Yes @rjleveque - the circular symbolic links are set up as part of the install.

@mandli
Copy link
Member

mandli commented Oct 20, 2014

Why is this only done when python setup.py git-dev is run? I also noticed some code in the setup.py that mentions un-symlinking this, is that not done in the git-dev case?

@ketch
Copy link
Member

ketch commented Mar 8, 2015

This is was resolved by #96.

@ketch ketch closed this as completed Mar 8, 2015
maojrs pushed a commit to maojrs/riemann that referenced this issue Mar 19, 2015
converted fvmbook/chap22/corner
maojrs pushed a commit to maojrs/riemann that referenced this issue Mar 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants