feat: Add support for tracing crate
#127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 11903211964Details
💛 - Coveralls |
epage
reviewed
Nov 18, 2024
- Add log feature flag (enabled by default)
- Move log specific code to `log` module
- Move top level re-exports of log types to `log` module
BREAKING CHANGE: The log crate is now an optional dependency, enabled by
default. The `log::Level` and `log::LevelFilter` types are now
re-exported from the `log` module rather than the crate root. If you
were using these types directly, you will need to update your imports.
```diff
-use clap_verbosity_flag::{Level, LevelFilter};
+use clap_verbosity_flag::log::{Level, LevelFilter};
```
It is no longer necessary to have to depend on both log and tracing-log to use clap-verbosity-flag with the tracing crate. This commit adds support for the tracing crate directly. - Add `tracing-core` as a dependency - Add `tracing` as a feature - Add `tracing` module - Remove `tracing-log` as a dependency for the `tracing` example
joshka
force-pushed
the
jm/tracing-support
branch
from
d6289a5 to
53b0316
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is no longer necessary to have to depend on both log and tracing-log
to use clap-verbosity-flag with the tracing crate. This commit adds
support for the tracing crate directly.
tracing-coreas a dependencytracingas a featuretracingmoduletracing-logas a dependency for thetracingexample