Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developed a plugin to group toolbar items #1473

Closed
wants to merge 1 commit into from

Conversation

dashingswags
Copy link

This package contains CKEditor 5 features allowing to group multiple toolbar items in a dropdown list using any custom ckeditor5 build

  1. Add "toolbargroup" to the toolbar.items array as shown below
  2. add a toolbarGroup object to the editor.config and set the required parameters.

The toolbarGroup accepts an option array with a model and title property respectively.

Values for the model is same as toolbar.items array, while the values for the title is optional. if you want a custom title, then you can set that option as desired

@Reinmar Reinmar mentioned this pull request Jan 21, 2019
@Reinmar
Copy link
Member

Reinmar commented Jan 21, 2019

Hi! This PR is really amazing – thank you for sharing it!

I started analyzing in #1472 what we really need, though, and I'm not sure if this is the right way to propose this functionality. And what kind of functionality we need. I'll keep your PR open for the time being, before my colleagues comment on this, but I'm afraid we'll need to implement it in a different way. Still, your plugin is very interesting and I'd love to see it on npm – I'm sure other developers will enjoy using it.

@Reinmar
Copy link
Member

Reinmar commented Apr 23, 2019

My late review landed in #1472 (comment). As I explained there, such a feature that you proposed would make a great sense as a 3rd party addon. Thanks again for the great PR, but we'd like to go in a different direction with the core.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants