Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The image upload success indicator does not fit small images #9165

Closed
oleq opened this issue Mar 5, 2021 · 2 comments · Fixed by #9194
Closed

The image upload success indicator does not fit small images #9165

oleq opened this issue Mar 5, 2021 · 2 comments · Fixed by #9194
Assignees
@magda-chrzescian
Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 41 (v27...

Comments

@oleq
Copy link
Member

oleq commented Mar 5, 2021

Instead of being displayed over an image (upper-right corner), it is displayed in the lower-right corner.

Screenshot 2021-03-05 at 09.17.04.png

This problem also occurred with block images but they were less likely to be uploaded so small because that would not make sense between the paragraphs. With inline images used as pseudo-bullets for lists etc. this will happen more often.
@oleq oleq added domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior. labels Mar 5, 2021
@oleq oleq added this to the iteration 41 milestone Mar 5, 2021
This was referenced Mar 5, 2021
Closed
Closed
@magda-chrzescian magda-chrzescian self-assigned this Mar 9, 2021
@magda-chrzescian
Copy link
Contributor

magda-chrzescian commented Mar 9, 2021 •
edited
Loading

As we agreed, I implemented the simplest solution for now, so the indicator will be hidden if an image is smaller than 50x50px.
image.png
This is how it looks like on the image right above the breakpoint.

@magda-chrzescian magda-chrzescian mentioned this issue Mar 9, 2021
Merged
@AnnaTomanek AnnaTomanek linked a pull request Mar 10, 2021 that will close this issue
Not displaying the complete icon for images smaller than 50x50. #9194
Merged
oleq added a commit that referenced this issue Mar 15, 2021
@oleq
Merge pull request #9194 from ckeditor/i/9165-upload-indicator-for-sm…
60e1fd2 
…all-images

Fix (image): The image upload success indicator should not be displayed for images smaller than 50x50px. Closes #9165.
@oleq
Copy link
Member Author

oleq commented Mar 15, 2021

Closed in https://app.zenhub.com/workspace/o/ckeditor/ckeditor5/issues/9194.

@oleq oleq closed this as completed Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@magda-chrzescian magda-chrzescian

Labels
domain:ui/ux This issue reports a problem related to UI or UX. package:image squad:core Issue to be handled by the Core team. type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 41 (v27.0.0)
Development

Successfully merging a pull request may close this issue.

Not displaying the complete icon for images smaller than 50x50. ckeditor/ckeditor5
2 participants
@oleq @magda-chrzescian