Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize model TreeWalker #6582

Closed
Reinmar opened this issue Apr 8, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1839
Closed

Optimize model TreeWalker #6582

Reinmar opened this issue Apr 8, 2020 · 2 comments · Fixed by ckeditor/ckeditor5-engine#1839
Assignees
@Reinmar
Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Milestone
iteration 31 (v19...

Comments

@Reinmar
Copy link
Member

Reinmar commented Apr 8, 2020

📝 Provide a description of the improvement

Followup of #6579.

TreeWalker accesses some of the "expensive" positions too many times.

If you'd like to see this improvement implemented, add a 👍 reaction to this post.
@Reinmar Reinmar added the type:improvement This issue reports a possible enhancement of an existing feature. label Apr 8, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Apr 8, 2020

Starting point:

@Reinmar Reinmar self-assigned this Apr 8, 2020
@Reinmar Reinmar added package:engine type:performance This issue reports a performance issue or a possible performance improvement. labels Apr 8, 2020
@Reinmar Reinmar added this to the iteration 31 milestone Apr 8, 2020
@Reinmar
Copy link
Member Author

Reinmar commented Apr 9, 2020

Got it down significantly :)

@Reinmar Reinmar mentioned this issue Apr 13, 2020
Merged
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Apr 14, 2020
@Reinmar
Merge pull request #1839 from ckeditor/i/6582
08e8294 
Other: Improved performance of `TreeWalker` by up to 40%. This optimization affects common tasks such as loading editor data. Closes ckeditor/ckeditor5#6582.
@mlewand mlewand mentioned this issue Apr 28, 2020
Closed
mlewand pushed a commit that referenced this issue May 1, 2020
@Reinmar
Merge pull request #1839 from ckeditor/i/6582
81387df 
Other: Improved performance of `TreeWalker` by up to 40%. This optimization affects common tasks such as loading editor data. Closes #6582.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Reinmar Reinmar

Labels
package:engine type:improvement This issue reports a possible enhancement of an existing feature. type:performance This issue reports a performance issue or a possible performance improvement.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

Improved performance of TreeWalker ckeditor/ckeditor5-engine
1 participant
@Reinmar