Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Horizontal alignment of the table cell is broken in RTL content #6371

Closed
oleq opened this issue Mar 3, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#283
Closed

Horizontal alignment of the table cell is broken in RTL content #6371

oleq opened this issue Mar 3, 2020 · 0 comments · Fixed by ckeditor/ckeditor5-table#283
Assignees
@niegowski
Labels
domain:rtl This issue reports a problem with support for right-to-left languages. intro Good first ticket. package:table type:bug This issue reports a buggy (incorrect) behavior.
Milestone
iteration 31 (v19...

Comments

@oleq
Copy link
Member

oleq commented Mar 3, 2020 •
edited
Loading

📝 Provide detailed reproduction steps (if any)

  1. http://localhost:8125/ckeditor5-table/tests/manual/rtl.html
  2. Open the cell props form.
  3. Play with the h-alignment.

✔️ Expected result

The content alignment should reflect the buttons.

❌ Actual result

The "left" alignment is not respected.

2020-03-03 14 01 12

📃 Other details

This is because of the default conversion designed for LTR. "left" was omitted because it's default..

Screenshot 2020-03-03 at 14 02 47

image

In the RTL content, it should be the other way around. Check out how the Alignment feature handles this for inspiration.

If you'd like to see this fixed sooner, add a 👍 reaction to this post.
@oleq oleq added type:bug This issue reports a buggy (incorrect) behavior. package:table domain:rtl This issue reports a problem with support for right-to-left languages. labels Mar 3, 2020
@oleq oleq mentioned this issue Mar 3, 2020
Merged
@Reinmar Reinmar added this to the next milestone Mar 4, 2020
@oleq oleq added the intro Good first ticket. label Mar 20, 2020
@niegowski niegowski modified the milestones: next, iteration 31 Mar 23, 2020
@niegowski niegowski mentioned this issue Mar 23, 2020
Merged
oleq added a commit to ckeditor/ckeditor5-table that referenced this issue Mar 26, 2020
@oleq
Merge pull request #283 from ckeditor/i/6371
b6ca42e 
Fix: The horizontal alignment of the table cell content should work properly with right–to–left languages. Closes ckeditor/ckeditor5#6371.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niegowski niegowski

Labels
domain:rtl This issue reports a problem with support for right-to-left languages. intro Good first ticket. package:table type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Milestone
iteration 31 (v19.0.0)
Development

Successfully merging a pull request may close this issue.

Fixed horizontal alignment of table cell in RTL content. ckeditor/ckeditor5-table
3 participants
@Reinmar @oleq @niegowski