Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Firefox] Placeholder doesn't disappear after clicking on it #469

Closed
Mgsy opened this issue Jun 12, 2017 · 5 comments
Closed

[Firefox] Placeholder doesn't disappear after clicking on it #469

Mgsy opened this issue Jun 12, 2017 · 5 comments
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Milestone

Comments

@Mgsy
Copy link
Member

Mgsy commented Jun 12, 2017

Steps to reproduce

  1. Open a sample with placeholders.
  2. Click few times on a placeholder.

Current result

Placeholder doesn't disappear.

Expected result

Placeholder should disappear when you click it.

Notes

Placeholder disappears only if you place a caret after text.

GIF

bug

Other information

OS: Windows 10
Browser: Firefox
Release: 0.10.0

@Mgsy Mgsy added the type:bug This issue reports a buggy (incorrect) behavior. label Jun 12, 2017
@Reinmar
Copy link
Member

Reinmar commented Jun 21, 2017

jun-21-2017 20-55-32

It's really bad with the caret appearing outside the <h2> because typing there will crash the editor.

@Reinmar Reinmar added this to the iteration 11 milestone Jun 21, 2017
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Jul 7, 2017
Reinmar added a commit to ckeditor/ckeditor5-engine that referenced this issue Jul 7, 2017
@Reinmar
Copy link
Member

Reinmar commented Jul 7, 2017

I fixed the second part of the issue by ckeditor/ckeditor5-engine@34498a8.

But I can't find why Firefox would ignore some clicks. It's also hard to find some rule when they are ignored.

@Reinmar
Copy link
Member

Reinmar commented Jul 7, 2017

Or... actually, it works nearly seamlessly now:

jul-07-2017 17-05-58

@Reinmar Reinmar closed this as completed Jul 7, 2017
@Reinmar
Copy link
Member

Reinmar commented Jul 7, 2017

@Mgsy, could you confirm whether it's better now?

@Mgsy
Copy link
Member Author

Mgsy commented Jul 14, 2017

@Mgsy, could you confirm whether it's better now?

Yes, I think it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package:engine type:bug This issue reports a buggy (incorrect) behavior.
Projects
None yet
Development

No branches or pull requests

2 participants