This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Added iterator interface to the Config class. #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reinmar
reviewed
Dec 5, 2019
src/config.js
Outdated
| * | ||
| * @returns {Iterable.<String>} | ||
| */ | ||
| [ Symbol.iterator ]() { |
There was a problem hiding this comment.
If it's iterating over names I'd create it under Config#names() or Config#keys() depending on how we call this thing. Similar to Map#keys() vs Map#iterator where the former iterates over prop names and the other over all entries.
There was a problem hiding this comment.
Done. I added a Config#names() method.
Reinmar
approved these changes
Dec 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Feature: Added iterator interface to the
Configclass. Part of ckeditor/ckeditor5#5891.Additional information
Required by the ckeditor/ckeditor5-core#204.
Editor#configneeds to be extended by theContext#config.