Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

I/6107: Add RTL support for table (cell) properties #269

Merged
merged 12 commits into from
Mar 9, 2020
Merged

I/6107: Add RTL support for table (cell) properties #269

merged 12 commits into from
Mar 9, 2020

Conversation

panr
Copy link
Contributor

@panr panr commented Mar 2, 2020

Suggested merge commit message (convention)

Other: Added RTL support for table and table cell properties. Closes ckeditor/ckeditor5#6107.

--

Main PR: ckeditor/ckeditor5-table#259

@panr panr changed the title I/6107: Add support RTL for table (cell) properties I/6107: Add RTL support for table (cell) properties Mar 2, 2020
@panr panr added the pr:sub label Mar 2, 2020
@oleq oleq self-requested a review March 3, 2020 12:49
Copy link
Member

@oleq oleq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes should land in different places.

Also, the remove color button icon's margins are asymmetrical in RTL (should be mirrored):

Screenshot 2020-03-03 at 13 17 39

theme/ckeditor5-table/tablecellproperties.css Outdated Show resolved Hide resolved
theme/ckeditor5-table/tableproperties.css Outdated Show resolved Hide resolved
@panr
Copy link
Contributor Author

panr commented Mar 9, 2020

@oleq I've moved the code to the ck-toolbar_compact class. Let me know if it is OK.

I wonder how to deal with this, without breaking anything else

margin-left: var(--ck-spacing-small);

Right now I made this fix: 6752738#diff-dd40ec07a00bed03a8fe3c711cd7ddb4R70

@oleq oleq merged commit 931351c into master Mar 9, 2020
@oleq oleq deleted the i/6107 branch March 9, 2020 15:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Table properties UI] RTL support
2 participants