Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

T/ckeditor5/1151: Adjusted InsertTableView for better compatibility with right–to–left (RTL) languages #196

Merged
merged 4 commits into from
Aug 12, 2019
Merged

T/ckeditor5/1151: Adjusted InsertTableView for better compatibility with right–to–left (RTL) languages #196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0ade6ef
Improved rendering of the InsertTableView geometry label for compatib…
oleq Jul 5, 2019
74ac9f9
Merge branch 'master' into t/ckeditor5/1151
oleq Jul 11, 2019
ae037c5
Merge branch 'master' into t/ckeditor5/1151
oleq Jul 25, 2019
92d8f87
Used the multiplication sign '×' instead of 'x' letter in the InsertT…
oleq Aug 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui/inserttableview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ export default class InsertTableView extends View {
* @member {String} #label
*/
this.bind( 'label' )
.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } x ${ columns }` );
.to( this, 'columns', this, 'rows', ( columns, rows ) => `${ rows } × ${ columns }` );

this.setTemplate( {
tag: 'div',
Expand Down
6 changes: 3 additions & 3 deletions tests/ui/inserttableview.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ describe( 'InsertTableView', () => {
} );

it( 'sets #label to default rows & columns', () => {
expect( view.label ).to.equal( '0 x 0' );
expect( view.label ).to.equal( '0 × 0' );
} );

it( 'creates #element from template', () => {
Expand Down Expand Up @@ -85,11 +85,11 @@ describe( 'InsertTableView', () => {
it( 'binds #label to rows & columns', () => {
view.rows = 3;

expect( view.label ).to.equal( '3 x 0' );
expect( view.label ).to.equal( '3 × 0' );

view.columns = 7;

expect( view.label ).to.equal( '3 x 7' );
expect( view.label ).to.equal( '3 × 7' );
} );

it( 'mousedown event should be prevented', () => {
Expand Down