Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Remove deprecated configuration option. #188

Merged
merged 4 commits into from
May 20, 2019
Merged

Remove deprecated configuration option. #188

merged 4 commits into from
May 20, 2019

Conversation

msamsel
Copy link
Contributor

@msamsel msamsel commented May 10, 2019

Suggested merge commit message (convention)

Other: Remove deprecated 'table.toolbar' configuration option. Closes ckeditor/ckeditor5#3259.

BREAKING CHANGE: config.table.toolbar is now removed from code. Use config.table.contentToolbarinstead.


Additional information

I remain configuration docs entry for this option. I think there should be some trace that such option existed. However Umberto doesn't mark it properly. It was removed as well after review comment.
Related issue ( https://github.com/cksource/umberto/issues/799 )

@coveralls
Copy link

coveralls commented May 10, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling d64c087 on t/167 into 00848a8 on master.

Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

table/table~TableConfig#toolbar property API docs should also be handled properly. We have two options:

  • we removed it all along,
  • we clearly mark that it was removed in version x.y.z.

I'd go with removing it all along, to not keep zombie API entries. Another reason for this is that with our iteration-based approach we don't know what is the version number that we're about to release (technically looking at the warning message we should release v13.0.0).


@@ -239,12 +239,11 @@ describe( 'TableToolbar', () => {
} );

describe( 'deprecated toolbar', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I don't think we need unit tests for removing a variable. Instead we should remove the suite all along.

@msamsel msamsel requested a review from mlewand May 14, 2019 08:28
@msamsel
Copy link
Contributor Author

msamsel commented May 14, 2019

During this task I also found missing docs. I made a separate PR for that #189.

@mlewand mlewand self-assigned this May 20, 2019
Copy link
Contributor

@mlewand mlewand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlewand mlewand merged commit 5d024ce into master May 20, 2019
@mlewand mlewand deleted the t/167 branch May 20, 2019 14:39
@mlewand mlewand removed their assignment May 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove support for deprecated table.toolbar.
3 participants