This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Lazy loading for the font color/bg dropdowns #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests will need to be adjusted.
mlewand
changed the title
Reinmar
reviewed
Feb 12, 2020
src/ui/colortableview.js
Outdated
| * @readonly | ||
| * @member {module:ui/colorgrid/colorgrid~ColorGridView} | ||
| * @member {module:ui/colorgrid/colorgrid~ColorGridView/undefined} |
Reinmar
reviewed
Feb 12, 2020
src/ui/colortableview.js
Outdated
| @@ -252,6 +240,38 @@ export default class ColorTableView extends View { | |||
| this.keystrokes.listenTo( this.element ); | |||
| } | |||
|
|
|||
| /** | |||
| * Renders and appends {@link #staticColorsGrid} and {@link #documentColorsGrid} views. | |||
There was a problem hiding this comment.
SRP – render or append. Or change the name at least.
There was a problem hiding this comment.
The thing here is that in order to append it it also has to render it first (and this is the most intense operation, which we want to avoid). I'll turn it into append then.
|
For me, the solution looks completely fine. I'm not saying that the surrounding code is good and I didn't even look at it. But this change itself is very similar to what we did in other plugins, so that sounds fine. |
|
Next goal – getting rid of this layout and style recalculations :) Fonts work fine now.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Other: Implemented lazy loading for the font color and background dropdown. This will reduce editor initialization time. Closes ckeditor/ckeditor5#6192.
Additional information
It's difficult to easily pull this optimization for the font color / bg plugin.
First of all this plugin stores its model in the view - so you need the view to have things running.
There's no clear UI and business logic separation for this plugin. For example,
ColorGridViewclass (so type that we'd like to defer) holds a selected color.It works, and the tests are passing - but the solution is not super pretty.