This repository has been archived by the owner on Jun 26, 2020. It is now read-only.
Reversed ReinsertOperation targets back to same graveyard holder
#892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame graveyard holder.
|
I pushed an integration test for this change to |
|
I can still reproduce issues with lists on this PR:
The following error is thrown:
Is it anyhow related? |
|
Probably, I'll look into this... |
|
So I'll mark this as R- for now. |
…n scripts that create `RemoveOperation` instance.
|
I've pushed a commit that should solve this issue. I wanted to propose that fix (from the last commit) anyway as a followup issue, but wasn't aware it was already needed. |
|
Will you also push a test to undo? |
|
Yes |
|
Done. |
Reinmar
added a commit
to ckeditor/ckeditor5-undo
that referenced
this pull request
Mar 28, 2017
Tests: Integration test for ckeditor/ckeditor5-engine#892.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested merge commit message (convention)
Fix: Reversed
ReinsertOperationtargets back to same graveyard holder from which the nodes were re-inserted. Closes ckeditor/ckeditor5#4029.