Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Allow creating namespaced domelements #1798

Merged
merged 3 commits into from
Oct 8, 2019
Merged

Allow creating namespaced domelements #1798

merged 3 commits into from
Oct 8, 2019

Conversation

Sebobo
Copy link
Contributor

@Sebobo Sebobo commented Oct 7, 2019 •
edited by pomek
Loading

Fix: Create valid namespaced elements. Closes ckeditor/ckeditor5#2088.

Additional information

@coveralls
Copy link

coveralls commented Oct 7, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 1f2d981 on Sebobo:t/1797 into 45c82be on ckeditor:master.

Reinmar
Reinmar reviewed Oct 7, 2019
View reviewed changes
src/view/domconverter.js Outdated Show resolved Hide resolved
Reinmar
Reinmar suggested changes Oct 7, 2019
View reviewed changes
Copy link
Member

@Reinmar Reinmar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! There are two small issues, as commented.

@Reinmar
Copy link
Member

Reinmar commented Oct 7, 2019

I can see that CC dropped too.

@Sebobo
Copy link
Contributor Author

Sebobo commented Oct 8, 2019

CC is now fine again too.

@Sebobo Sebobo requested a review from Reinmar October 8, 2019 09:08
@Reinmar Reinmar merged commit a9190c9 into ckeditor:master Oct 8, 2019
@Reinmar
Copy link
Member

Reinmar commented Oct 8, 2019

Thanks!

@Reinmar Reinmar mentioned this pull request Oct 8, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Reinmar Reinmar Awaiting requested review from Reinmar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support creation of namespaced elements
3 participants
@Sebobo @coveralls @Reinmar