Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

Allow to pass initial data to the editor constructor #19

Merged
merged 13 commits into from
Jul 3, 2018
Merged

Conversation

szymonkups
Copy link
Contributor

@szymonkups szymonkups commented May 15, 2018

Suggested merge commit message (convention)

Feature: Editor can be created with initial data passed to the constructor. Closes ckeditor/ckeditor5#2342.

BREAKING CHANGE: BalloonEditor#element is now available as BalloonEditor#sourceElement. See ckeditor/ckeditor5#2882.

Requires: ckeditor/ckeditor5-core#129

@szymonkups szymonkups requested a review from Reinmar May 15, 2018 16:39
@coveralls
Copy link

coveralls commented May 15, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 14009af on t/18 into 03af1c0 on master.

Copy link
Member

@pomek pomek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I improved a little the manual test. Except that, everything looks and works fine.

@Reinmar
Copy link
Member

Reinmar commented Jun 6, 2018

…rWithUI interfeace (added editor.element property).
@Reinmar Reinmar merged commit 48c265c into master Jul 3, 2018
@Reinmar Reinmar deleted the t/18 branch July 3, 2018 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set data in constructor instead of element
4 participants