Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a package directory when npm says it was published #1043

Merged
merged 1 commit into from
Oct 29, 2024
Merged

Conversation

psmyrek
Copy link
Contributor

@psmyrek psmyrek commented Oct 29, 2024

Suggested merge commit message (convention)

Other (release-tools): The publishPackageOnNpmCallback() util removes a package directory if npm says it was published. This reverts commit a1b37c7. Closes ckeditor/ckeditor5#17348.


Additional information

For example – encountered issues, assumptions you had to make, other affected tickets, etc.

…ve a package directory even if npm says it was published. Closes ckeditor/ckeditor5#17322."

This reverts commit a1b37c7.
@psmyrek psmyrek requested a review from martnpaneq October 29, 2024 07:55
@psmyrek psmyrek merged commit 735d7ec into master Oct 29, 2024
7 checks passed
@psmyrek psmyrek deleted the ck/17348 branch October 29, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release tools - assume npm publish did the job when returns a zero exit code
2 participants