feat: add verify inclusion proof to cli #95
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ariard
reviewed
Nov 26, 2023
src/proto/adminctrl.proto
Outdated
| @@ -143,3 +144,10 @@ message GenerateTxInclusionProofRequest { | |||
| message GenerateTxInclusionProofReply { | |||
| string merkle_block = 1; | |||
| } | |||
|
|
|||
| message VerifyInclusionProofRequest { | |||
There was a problem hiding this comment.
Good if we can move those methods on the civkitservice.proto interface. That way they can be reused by notaryd in the future.
| @@ -71,6 +73,7 @@ impl ServiceManager | |||
| send_bitcoind_request: Mutex::new(send_bitcoind_request), | |||
| send_events_gateway: Mutex::new(send_gateway_events), | |||
| our_service_pubkey: pubkey, | |||
| inclusion_proof: inclusion_proof, | |||
There was a problem hiding this comment.
Good to integrate it like this, when the mainstay module is more encapsulated, it can be moved in notaryd.
|
Note the inclusion proof verification interface can be integrated in |
|
See #95, it’s taking it over with fixes. Thanks for the fixes from latest review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.