CIWEMB-376: Update table styles #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice @ahed-compucorp ! A few small comments - |
|
@jamienovick , I've updated the styles and removed both the top border from the table and the shadow from the pager. |
ahed-compucorp
force-pushed
the
CIWEMB-376-fix-table-styles
branch
from
9e70501 to
d4fabdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates search kit tables and default table styles.
Before - Search kit tables
After - Search kit tables
Before - default tables
After - default tables
Technical Details
We try to tweak the styles to make the search kit tables match the theme styles (mainly the padding and the pager to be similar to other tables). Please note, the search kit uses the table-striped to add the striped effect.
Also, updated the default table styles to match other CiviCRM core tables.