CATL-1660: Fix Select 2 styles #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb1990
force-pushed
the
CATL-1660-fix-tags-ui
branch
from
0a379a9 to
cc8b578
Compare
deb1990
force-pushed
the
CATL-1660-fix-tags-ui
branch
from
cc8b578 to
855dcc0
Compare
deb1990
force-pushed
the
CATL-1660-fix-tags-ui
branch
from
89d5669 to
833005c
Compare
reneolivo
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When having an item with long name inside the Select 2, the UI used to break. This PR fixes that.
Before
After
Technical Details
In
scss/bootstrap/overrides/vendors/_select2.scss, addedheight: 100%, to fix the original issue in compucorp/uk.co.compucorp.civicase#279. Now the code from Civicase is removed, as this height is enough to fix the issue.In
scss/jquery/overrides/_select2.scss, addedword-break: break-all, so that long words break, instead of breaking the UI.Backstop Test : https://github.com/compucorp/backstopjs-config/actions/runs/711467592
Added SCSS Linter as part of build process.
Updated Node JS version to latest LTS i.e 14.16.0.
Also updated
gulp-sassto latest.