CPS-378: Fix Case Status labels #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deb1990
force-pushed
the
CPS-378-case-status-labels-fix
branch
from
2923420 to
d615ce0
Compare
deb1990
changed the title
reneolivo
approved these changes
Mar 30, 2021
| 3. _What the override/patch consists of_ | ||
|
|
||
| ## Comments | ||
| _Anything else you would like the reviewer to note_ |
There was a problem hiding this comment.
why not add the backstop block here as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When the Case Status had a Dark Colored background in the Option Settings, the Case Status label were shown as white text on white background, this PR fixes that problem.
Before
After
Technical Details
The Background Color of Case Status label should ideally be same as the color set in Option Settings.
But in
scss/civicrm/common/_tables.scss, the Background was forced to Color White using!important, and that ignored the inline background color styles.Now
!importantis removed, and individual styles are tables to tables where this White Background needs to be forced.Comments
Backstop Tests are done in https://github.com/compucorp/backstopjs-config/actions/runs/700673399