Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW-382: Styled Individual casetype setting page #49

Merged

Conversation

mukeshcompucorp
Copy link
Contributor

@mukeshcompucorp mukeshcompucorp commented Sep 8, 2017

Before:
before

After:
after-2

Note:

@colemanw
Copy link
Member

colemanw commented Sep 8, 2017

@mukeshcompucorp if this screen could be improved by adding standard crm classes to it to prevent you from needing these extra style rules in shoreditch, please go ahead and submit a pr for that to civicrm-core.

@jamienovick
Copy link

Also @mukeshcompucorp visually - Im not sure the section showing the top "save and cancel" should have the big block. In fact if @colemanw agrees I would remove those buttons completely in a separate PR. Having save and cancel at the bottom is enough?

@colemanw
Copy link
Member

colemanw commented Sep 8, 2017

I agree we don't need them twice, although it is a standard convention on most Civi forms to have buttons at the top and the bottom.

@mukeshcompucorp
Copy link
Contributor Author

@colemanw We do not need any global class for now.
@jamienovick we keep such big block for all pages for any crm buttons either on top or bottom though, let's decide if we want to remove it then either you or me can remove it from core file and submit a separate PR for that to @colemanw

}
}

.crm-block {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see this block padding being fixed multiple times, shouldn't we have a generic css rule that fixes it once and for all?


.crmCaseType {

.crm-button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't any button be styled automatically at this point? Why do the buttons on this screen require specific styling? Is the markup different?

davialexandre pushed a commit that referenced this pull request Oct 6, 2017
@AkA84 AkA84 merged commit 195f66a into civicrm:develop Oct 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants