-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW-382: Styled Individual casetype setting page #49
HW-382: Styled Individual casetype setting page #49
Conversation
@mukeshcompucorp if this screen could be improved by adding standard crm classes to it to prevent you from needing these extra style rules in shoreditch, please go ahead and submit a pr for that to civicrm-core. |
Also @mukeshcompucorp visually - Im not sure the section showing the top "save and cancel" should have the big block. In fact if @colemanw agrees I would remove those buttons completely in a separate PR. Having save and cancel at the bottom is enough? |
I agree we don't need them twice, although it is a standard convention on most Civi forms to have buttons at the top and the bottom. |
@colemanw We do not need any global class for now. |
} | ||
} | ||
|
||
.crm-block { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this block padding being fixed multiple times, shouldn't we have a generic css rule that fixes it once and for all?
|
||
.crmCaseType { | ||
|
||
.crm-button { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't any button be styled automatically at this point? Why do the buttons on this screen require specific styling? Is the markup different?
PCHR-2653: Fix Admin header issue
Before:
After:
Note: