SHOR-111: Upgrade to bootstrap 3.4 #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishing the job started with #337
Both bootstrap and bootstrap-sass have now released v3.4, so this PR points Shoreditch to that specific version instead of generically using the
nextbranch of the bootstrap-sass projectNote
The vast majority of changes in this PR on the vendor files are most likely coming from automatic fixes from linters (using
:instead of::for pseudo elements, shuffling bits of code around etc).The rest of the changes seems to be caused simply by the bootstrap-sass
nextbranch not being fully synced with the then-future 3.4 release at the time we merged #337