Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Revert #18005 Fix buggy placement of icons" #18345

Closed
wants to merge 1 commit into from

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Sep 3, 2020

Overview

Re-apply #18005 for 5.31 - it was reverted out of 5.29 purely due to the timing being too short to communicate

This reverts commit 353282c.

@civibot
Copy link

civibot bot commented Sep 3, 2020

(Standard links)

@civibot civibot bot added the master label Sep 3, 2020
@demeritcowboy
Copy link
Contributor

I compared the two PRs and except for ckeditor which got moved as part of the recent security update where it's already changed to remove the css class they're the same.

@eileenmcnaughton
Copy link
Contributor Author

@colemanw so we have communicated about this now - do you want to re-check this & the follow up fix - the follow up fix it the bigger one

@agh1
Copy link
Contributor

agh1 commented Sep 8, 2020

I'm preparing a new PR now that combines the commits from #18005 and #18087 because it's probably simpler to manage that way.

@agh1
Copy link
Contributor

agh1 commented Sep 8, 2020

See #18410 for the big combined button PR for 5.31

@eileenmcnaughton
Copy link
Contributor Author

Closing as replaced ^^

@eileenmcnaughton eileenmcnaughton deleted the flatties branch September 8, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants