Add prorated fees for open term loans #79
Conversation
|
|
||
| fundingVault.withdraw(amount, _pool); | ||
| emit FundsReclaimed(amount, _pool); | ||
| } |
There was a problem hiding this comment.
Should we allow this for fixed term loans if the loan is in a terminal state?
There was a problem hiding this comment.
It seems like if we allow closed-term borrowers to hit paydownPrincipal, then we should allow pool admins to call this function too? Otherwise funds would sit here I think. Alternatively we can restrict paydown to only be for open-term borrowers.
For open-term, do we need to also to use the callbackTimestamp anywhere? I thought that would gate PAs being able to reclaim funds, but I think I misunderstood it.
There was a problem hiding this comment.
I want to go ahead and stick with the predefined specs for the loans and be a little more strict, but will come up when we review money flows
I think the whole point of the callbackTimestamp is to reflect on-chain when the event happened. There really is nothing else to do with it. Funds will either be fully returned by the borrower or the PA will mark the loan in default. They can mark the default at their discretion at anytime though, so there is no restriction on it.
| @@ -355,15 +414,16 @@ contract Loan is ILoan { | |||
| liquidityAsset, | |||
| IPool(_pool).firstLossVault(), | |||
| firstLossFee, | |||
| IPool(_pool).manager(), | |||
| IPool(_pool).feeVault(), | |||
There was a problem hiding this comment.
the fee vault should be used in this scenario as it is for a normal payment. We could optimize out the fee vault though if we wanted
| principal: 500_000, | ||
| loanType: 1, | ||
| originationBps: 100, | ||
| poolFeePercentOfInterest: 100 |
There was a problem hiding this comment.
intentionally using all the fees to be sure they're all taken care of
|
|
||
| return amount; | ||
| } | ||
|
|
||
| function paydownPrincipal(uint256 amount) external onlyBorrower { |
There was a problem hiding this comment.
Do we want / need a check that they don't overpay? Also, would there be any reason to limit this to open-term loans?
There was a problem hiding this comment.
Good call, also added check on overpaying as well
| @@ -334,13 +353,52 @@ contract Loan is ILoan { | |||
| return payment; | |||
| } | |||
|
|
|||
| function previewFees(uint256 amount) | |||
There was a problem hiding this comment.
In the future work, it might be nice to have a previewPayment function that previews the next payment + fees
|
|
||
| fundingVault.withdraw(amount, _pool); | ||
| emit FundsReclaimed(amount, _pool); | ||
| } |
There was a problem hiding this comment.
It seems like if we allow closed-term borrowers to hit paydownPrincipal, then we should allow pool admins to call this function too? Otherwise funds would sit here I think. Alternatively we can restrict paydown to only be for open-term borrowers.
For open-term, do we need to also to use the callbackTimestamp anywhere? I thought that would gate PAs being able to reclaim funds, but I think I misunderstood it.
Hoping to get a quick pair of eyes on this.
I found the fees convoluted because:
I think a good next step would be to extract each fee to its own function. That or have one function for fixed and one for open-term.