VAL-39 Apply first-loss to the pool in case of default #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Oct 17, 2022
| @@ -78,17 +78,17 @@ interface ILoan { | |||
| /** | |||
| * @dev Number of payments remaining | |||
| */ | |||
| function paymentsRemaining() external returns (uint256); | |||
| function paymentsRemaining() external view returns (uint256); | |||
There was a problem hiding this comment.
Pretty sure these can / should be view, right?
venables
approved these changes
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that the updates to Loan/ILoan are temporary -- I tried to piggy-back off the expected changes from #47, since they're needed here. Once that lands I'll rebase this PR and the diff will be smaller.
Edit: rebased, should be g2g.