Add Pool Access Control methods #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venables
commented
Sep 26, 2022
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "extends": "solhint:recommended", | |||
| "rules": { | |||
| "compiler-version": ["error", "^0.8.16"] | |||
| "compiler-version": ["error", "^0.8.16"], | |||
| "func-visibility": ["warn", { "ignoreConstructors": true }] | |||
There was a problem hiding this comment.
This is recommended to be set to true for solidity >= 0.7.0
ams9198
reviewed
Sep 27, 2022
| @@ -321,6 +320,7 @@ contract Pool is IPool, ERC20 { | |||
| */ | |||
| function deposit(uint256 assets, address receiver) | |||
| external | |||
| virtual | |||
There was a problem hiding this comment.
Do we need to cover off on the mint as well?
I also notice per the EIP 4626 re: maxMint, maxDeposit: MUST factor in both global and user-specific limits, which I interpret to mean incorporating ACL policies? Not sure how we want to handle that (can also punt).
ams9198
approved these changes
Sep 27, 2022
| } | ||
|
|
||
| /** | ||
| * @inheritdoc Pool |
There was a problem hiding this comment.
Nice 👍 I also even like the shorthand /// @inheritdoc style too.
| * @dev Modifier that checks that the caller is the pool's manager. | ||
| */ | ||
| modifier onlyManagerOfPool() { | ||
| require(msg.sender == _pool.manager(), "Pool: caller is not manager"); |
There was a problem hiding this comment.
Nice, was wondering how we'd handle the case of a pool switching manager's, and needing to update this contract, but this makes sense to just store the pool address 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a few things:
ServiceConfigurable, as it was causing issues with inheritance. For now, these methods will be explicitly declared in each contract.