VAL-143 Snapshot the pool on all loan payments #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
February 17, 2023 10:23
… to the proper withdraw period (as per the scenario spec)
ams9198
commented
Feb 17, 2023
| @@ -191,11 +194,15 @@ describe("Business Scenario 1", () => { | |||
| ); | |||
| await loanOne.connect(borrowerOne).completeFullPayment(); | |||
|
|
|||
| // +14 days, request full withdrawal at start of 2nd window | |||
| await advanceToDay(startTime, 14); | |||
| // +15 days, request full withdrawal at start of 2nd window | |||
There was a problem hiding this comment.
This was actually a bug with the existing test -- +14 days didn't actually advance us to the expected window (the next one). This only became apparent with the loan payments triggering a snapshot.
ams9198
commented
Feb 17, 2023
| @@ -241,8 +241,8 @@ describe("Permissioned Business Scenario 1", () => { | |||
| ); | |||
| await loanOne.connect(borrowerOne).completeFullPayment(); | |||
|
|
|||
| // +14 days, request full withdrawal at start of 2nd window | |||
| await advanceToDay(startTime, 14); | |||
| // +15 days, request full withdrawal at start of 2nd window | |||
There was a problem hiding this comment.
Same comment as above.
ams9198
commented
Feb 17, 2023
| @@ -263,8 +263,8 @@ describe("Permissioned Business Scenario 1", () => { | |||
| ); | |||
| await loanTwo.connect(borrowerTwo).completeFullPayment(); | |||
|
|
|||
| // Request window is 14 days, so fast forward to +28 days to claim in next window | |||
| await advanceToDay(startTime, 28); | |||
| // Request window is 14 days, so fast forward to +29 days to claim in next window | |||
There was a problem hiding this comment.
Same comment as above
venables
approved these changes
Feb 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.