VAL-134 Add missing permissioning checks around the Loan #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
venables
previously approved these changes
Feb 13, 2023
added 11 commits
February 14, 2023 10:00
…rawing collateral
…wing protocol permissioning to be applied. Update existing tests + add new tests to cover this new exposed method - PoolController.reclaimLoanFunds.
…er layer so global permissioning can be applied.
…oller layer so global permissioning can be applied.
venables
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The diff ended up being larger than I'd like, but its mostly adding additional tests.
The core changes are:
Permissioning for the borrower:
Loan.claimCollateral, ensure we do apermittedLendercheck if the borrower is callingPermissioning for the PA:
Loan.markCallback- pipe the call through the PoolController so that permissioning can be appliedLoan.claimCollateral- sameLoan.reclaimFunds- sameLoan.cancelFunded- sameThe PA should not be calling directly into the Loan now, only via the PoolController.
Things to review in depth:
We were missing a
PermissionedPoolController.test.ts, so I added that and put a bunch of the new test cases in there.