VAL-132 Allow cancellation of full requested balance #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit adds a failing test, with a comment, demonstrating how a full
requestedBalancecan't be zeroed out. 2nd commit adds the fix.Previously,
maxRequestCancellationwould returntotal requested and eligible balance MINUS fees applied against that total. Then, when canceling, the fees would be burned, and then canceled amount would be subtracted from your requestedBalance. With fee > 0, this is always strictly less than your total requested balance, preventing a full cancel.With this change,
maxRequestCancellationjust returns the requested balance.