Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VAL-81] Remove TODOs from code #161

Merged
merged 1 commit into from
Dec 14, 2022
Merged

[VAL-81] Remove TODOs from code #161

merged 1 commit into from
Dec 14, 2022

Conversation

venables
Copy link
Contributor

  • Updated the tests to handle TODOS for checking on closed , paused pools.
  • Most TODOs were in tests for checking non 1:1 math, which is covered in other test cases, so I removed for now.
  • Added a story to update the ToS registry, so the TODO lives in JIRA now.

@venables venables changed the title Remove TODOs from code [VAL-81] Remove TODOs from code Dec 14, 2022
@venables venables merged commit 41de3c5 into circlefin:master Dec 14, 2022
@venables venables deleted the matt/val-81-remove-todos branch December 14, 2022 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ams9198 ams9198 ams9198 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@venables @ams9198