Verite integration updates #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bricestacey
commented
Dec 14, 2022
ams9198
reviewed
Dec 14, 2022
| _supportedCredentialSchemas[verificationResult.schema], | ||
| "INVALID_SCHEMA" | ||
| ); | ||
| require(_supportedCredentialSchemas[schema], "INVALID_SCHEMA"); |
There was a problem hiding this comment.
Just so I understand -- we're treating multiple schemas as a single schema, is essence? And does order matter? If there are schemas A,B, and C, and we only support A and B, would we need to register AB and BA? With many schemas, would that get complex to manage?
Another option might be to keep them as separate entries in the mapping, and then iterate here to check that each is included. On registration, we would iterate as well. Just a thought.
There was a problem hiding this comment.
yes, in this case they must have all the schemas and they're treated as a single schema in essence
ams9198
reviewed
Dec 14, 2022
venables
approved these changes
Dec 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the VeriteAccessControl contract to support Circle's verifier, specifically the new array of schemas.
I have some things that need to be cleaned up, but overall wanted to get this visible for comments ASAP