Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow anyone to submit a verification result #148

Merged
merged 2 commits into from
Dec 9, 2022
Merged

Allow anyone to submit a verification result #148

merged 2 commits into from
Dec 9, 2022

Conversation

venables
Copy link
Contributor

@venables venables commented Dec 9, 2022

No description provided.

For some reason, this specific string was causing a Bytecode error in
the openzeppelin contract during an upgrade test:

```
  Error: Bytecode is not a valid hex string
  at hashBytecode (node_modules/@openzeppelin/upgrades-core/src/version.ts:31:11)
  at hashBytecodeWithoutMetadata (node_modules/@openzeppelin/upgrades-core/src/version.ts:47:10)
  at getVersion (node_modules/@openzeppelin/upgrades-core/src/version.ts:14:24)
  at getUnlinkedBytecode (node_modules/@openzeppelin/upgrades-core/src/validate/query.ts:130:33)
  at getDeployData (node_modules/@openzeppelin/hardhat-upgrades/src/utils/deploy-impl.ts:48:47)
  at async deployProxyImpl (node_modules/@openzeppelin/hardhat-upgrades/src/utils/deploy-impl.ts:72:22)
  at async Proxy.upgradeProxy (node_modules/@openzeppelin/hardhat-upgrades/src/upgrade-proxy.ts:25:32)
at async Context.<anonymous> (test/permissioned/PoolAdminAccessControl.test.ts:178:7)
  ```
@venables venables merged commit da92599 into circlefin:master Dec 9, 2022
@venables venables deleted the matt/allow-anyone-to-post-verification branch December 9, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants