VAL-118 Make PoolAccessControl and PoolAdminAccessControl upgradeable #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Dec 8, 2022
| address factory_, | ||
| address borrower_, | ||
| address pool_, | ||
| address liquidityAsset_, | ||
| ILoanSettings memory settings_ | ||
| ) public virtual initializer { | ||
| _serviceConfiguration = IServiceConfiguration(serviceConfiguration); | ||
| _serviceConfiguration = IServiceConfiguration(serviceConfiguration_); |
There was a problem hiding this comment.
Variable shadowing fix
ams9198
commented
Dec 8, 2022
| @@ -149,7 +149,7 @@ contract Pool is IPool, ERC20Upgradeable, IBeaconImplementation { | |||
| poolController = IPoolController( | |||
| IPoolControllerFactory(poolControllerFactory).createController( | |||
| address(this), | |||
| serviceConfiguration, | |||
| serviceConfiguration_, | |||
There was a problem hiding this comment.
Same - shadowing warning
ams9198
commented
Dec 8, 2022
| DeployerUUPSUpgradeable | ||
| { | ||
| function initialize() public initializer { | ||
| __EIP712_init("VerificationRegistry", "1.0"); |
There was a problem hiding this comment.
Since VeriteAccessControl now uses the contracts-upgradeable, this had to be updated too
added 2 commits
December 8, 2022 11:23
venables
approved these changes
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds some dedicated tests for the base / abstract classes used throughout.