Add pauser role and user it in service config #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
previously approved these changes
Dec 2, 2022
ams9198
reviewed
Dec 3, 2022
contracts/ServiceConfiguration.sol
Outdated
| @@ -74,6 +79,7 @@ contract ServiceConfiguration is AccessControl, IServiceConfiguration { | |||
| * owners. | |||
| */ | |||
| constructor() { | |||
| _setupRole(DEFAULT_ADMIN_ROLE, msg.sender); | |||
| // Grant the contract deployer the Operator role | |||
| _setupRole(OPERATOR_ROLE, msg.sender); | |||
There was a problem hiding this comment.
Think it's worth deferring this, and letting the Admin grant the OPERATOR role in a separate transaction?
venables
reviewed
Dec 7, 2022
| const serviceConfiguration = await pool.serviceConfiguration(); | ||
| const ServiceConfiguration = await ethers.getContractFactory( | ||
| "ServiceConfiguration" | ||
| ); |
There was a problem hiding this comment.
This is fine, but the deployPool method from the fixture also returns the serviceConfiguration you can use instead of this
venables
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.