Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No ticket] Rename functions for consistency #123

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[No ticket] Rename functions for consistency #123

merged 1 commit into from
Dec 1, 2022

Conversation

ams9198
Copy link
Contributor

@ams9198 ams9198 commented Dec 1, 2022

This renames:

  • notifyLoanStateTransition --> onLoanStateTransitioned
  • notifyLoanPrincipalReturned --> onLoanPrincipalReturned

This is more consistent with existing the onActivated method in the Pool, and is common convention for this sort of hook.

@ams9198 ams9198 merged commit 0e5ecdd into circlefin:master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@venables venables venables approved these changes

@bricestacey bricestacey bricestacey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ams9198 @bricestacey @venables