VAL-111 Defaults only apply FL to cover the loan principal #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ams9198
commented
Nov 30, 2022
| uint256 amount, | ||
| uint256 outstandingLoss | ||
| ); | ||
| event FirstLossApplied(address indexed loan, uint256 amount); |
There was a problem hiding this comment.
The last argument felt like more trouble than it's worth, especially given that these terms aren't so easily defined...
There was a problem hiding this comment.
makes sense, could always query the loan for the outstanding debt anyway.
bricestacey
approved these changes
Dec 1, 2022
| uint256 amount, | ||
| uint256 outstandingLoss | ||
| ); | ||
| event FirstLossApplied(address indexed loan, uint256 amount); |
There was a problem hiding this comment.
makes sense, could always query the loan for the outstanding debt anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.