VAL-104 Run crank lazily #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 28, 2022 18:39
ams9198
commented
Nov 29, 2022
| @@ -129,7 +138,7 @@ interface IPool is IERC4626 { | |||
| /** | |||
| * @dev Cranks the pool's withdrawals | |||
| */ | |||
| function crank() external returns (uint256); | |||
| function crank() external; | |||
There was a problem hiding this comment.
Can add this back in, but since we're emitting an event with more information, felt duplicative?
There was a problem hiding this comment.
The return value doesn't seem very meaningful anyway. I can't think of an on-chain use case off the top of my head.
added 2 commits
November 29, 2022 12:41
bricestacey
approved these changes
Nov 29, 2022
| @@ -129,7 +138,7 @@ interface IPool is IERC4626 { | |||
| /** | |||
| * @dev Cranks the pool's withdrawals | |||
| */ | |||
| function crank() external returns (uint256); | |||
| function crank() external; | |||
There was a problem hiding this comment.
The return value doesn't seem very meaningful anyway. I can't think of an on-chain use case off the top of my head.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This runs the crank lazily on several mutating Pool functions (let me know if I missed some, or if this is too burdensome..).
Gas cost for a crank that actually does something is ~330k, for one that short-circuits, around 110k.
The behavior of the global crank was also tweaked slightly -- if there's 0 shares to redeem, that still "counts" as the crank for that period, and it can't be re-run in that period. I also added a
PoolCrankedevent that's emitted when the crank runs for that period.The mutating functions that the crank lazily executes on are:
In the PermissionedPool, it can be called directly via the PoolController / PA, or from a "valid participant"; in the Pool.sol, anyone can run it.