Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added getters to each geom::Object based off of available setters #2289

Closed

Conversation

morphogencc
Copy link
Contributor

Following the suggestion in #1176, I created getters for each geom::Object type based only on what setters were available.

@andrewfb
Copy link
Collaborator

Thanks for this, Nathan. I'm up to merge this (the presence of these accessors doesn't really conflict with any of the "philosophical" questions regarding the purpose of the geom types raised previously, IMO). That said, are you able to re-submit the PR where just GeomIo.h has been modified? It looks like some other changes made their way into this PR (hence the 46 files changes).

@morphogencc
Copy link
Contributor Author

Ah, I missed that! Will resubmit.

@morphogencc morphogencc deleted the feature-geomGetters branch July 14, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants